commit f982bfb21414dc23a824ffbf0111a97372addf7c Author: Travis Reitter Date: Thu May 12 15:51:20 2011 -0700 Release Folks 0.5.1. backends/tracker/lib/trf-persona-store.vala | 8 ++++---- configure.ac | 10 +++++----- folks/backend-store.vala | 2 +- folks/backend.vala | 2 +- folks/debug.vala | 26 +++++++++++++------------- folks/email-details.vala | 2 +- folks/field-details.vala | 6 +++--- folks/group-details.vala | 2 +- folks/im-details.vala | 2 +- folks/individual-aggregator.vala | 10 +++++----- folks/individual.vala | 6 +++--- folks/local-id-details.vala | 2 +- folks/note-details.vala | 2 +- folks/persona-store.vala | 4 ++-- folks/phone-details.vala | 2 +- folks/postal-address-details.vala | 4 ++-- folks/potential-match.vala | 2 +- folks/role-details.vala | 2 +- folks/url-details.vala | 2 +- folks/web-service-details.vala | 2 +- 20 files changed, 49 insertions(+), 49 deletions(-) commit c8d1babd0e9eeac6ec2d1b1c1a7cf113278b17e8 Author: Travis Reitter Date: Fri May 13 09:35:13 2011 -0700 Generate backend library headers in folks/ subdirs. This is to allow in-tree building, since we changed the includedir, which makes the vapi files include headers as . Outputting our headers in a folks/ subdir works around this issue by making the backend/*/lib dir match the expected includedir layout. backends/libsocialweb/Makefile.am | 1 + backends/libsocialweb/lib/Makefile.am | 6 +++--- backends/telepathy/Makefile.am | 1 + backends/telepathy/lib/Makefile.am | 6 +++--- backends/tracker/Makefile.am | 1 + backends/tracker/lib/Makefile.am | 6 +++--- 6 files changed, 12 insertions(+), 9 deletions(-) commit 3bc8ec29a4bee93960dd22886f633008a2597e5e Author: Travis Reitter Date: Thu May 12 22:20:40 2011 -0700 Don't depend upon removed LinkedHashSet stamp file. configure.ac | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) commit d9f7cf4277258c6ad4f28fa07bcc4ac072e80de0 Author: Travis Reitter Date: Thu May 12 16:36:22 2011 -0700 Strip tab characters from valadocs to unbreak doc building. folks/debug.vala | 36 ++++++++++++++++++------------------ 1 files changed, 18 insertions(+), 18 deletions(-) commit 59c0e7bf68e52a92f6e501e7c70786f40926cde7 Author: Travis Reitter Date: Thu May 12 22:59:17 2011 -0700 Properly distribute the typelib file. folks/Makefile.am | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) commit 6eae871cc2b1753f38a0a299c0e495621df5391f Author: Travis Reitter Date: Thu May 12 22:55:49 2011 -0700 Distribute Folks-*.gir and Folks-*.typelib folks/Makefile.am | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) commit 07ce4077e62b4adbf3191249ddb355512cca5bde Author: Travis Reitter Date: Thu May 12 22:54:35 2011 -0700 Allow generated source files to exist after distcleancheck. It turns out to be nearly impossible to satisfy a standard distcleancheck with Vala and its automake support. This is specifically a work-around because there doesn't seem to be any obvious way to satisfy these requirements: * the release tarball can be built without gobject-introspection, valac, or vapigen * it's safe to run "make distclean" in the release tarball without suddenly requiring the tools listed above (due to generated files being removed) * "make distcheck" doesn't fail its "distcleancheck" phase due to the following files remaining after distclean: - tests/lib/telepathy/contactlist/tp-test-contactlist.gir - tests/lib/telepathy/contactlist/tp-test-contactlist.vapi - backends/telepathy/lib/tp-lowlevel.gir - backends/telepathy/lib/tp-lowlevel.vapi We've hit this last issue multiple times, and no fix seems to stick. So stripping out this check seems to be the best option (until we can remove the Vala/GObject-Introspection-free build requirement, when they've stabilized more and we don't depend upon the latest versions which may not be in all the major distros). Makefile.am | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) commit e2f7b5916b566b81cf148b81c266cb95af436d47 Author: Travis Reitter Date: Thu May 12 14:00:02 2011 -0700 Allow the types argument for PostalAddress() to be null. folks/postal-address-details.vala | 11 +++++++---- 1 files changed, 7 insertions(+), 4 deletions(-) commit 58cc29fd89f7c81b6d5f42cbf5021657bcae7eda Author: Philip Withnall Date: Sun May 1 22:12:47 2011 +0100 Bug 649088 — Combining contacts doesn't work with german Umlauts Fix normalisation of Jabber IDs to use the correct Unicode normalisation mode as described in RFC 3920, §A.4. Closes: bgo#649088 NEWS | 1 + folks/im-details.vala | 14 +++++++------- 2 files changed, 8 insertions(+), 7 deletions(-) commit a9f6a07dc97e309261fa20a9b765afefe2affdf2 Author: Alexander Larsson Date: Tue May 10 13:11:05 2011 +0200 Ensure includes are done with This changes all pc files to not include -I$incdir/folks and fixes the vapi files to add the folks/ part to the includes. https://bugzilla.gnome.org/show_bug.cgi?id=649790 NEWS | 3 +++ backends/libsocialweb/lib/Makefile.am | 1 + backends/libsocialweb/lib/folks-libsocialweb.pc.in | 2 +- backends/telepathy/lib/Makefile.am | 1 + backends/telepathy/lib/folks-telepathy.pc.in | 2 +- backends/tracker/lib/Makefile.am | 1 + backends/tracker/lib/folks-tracker.pc.in | 2 +- folks/Makefile.am | 1 + folks/folks-uninstalled.pc.in | 2 +- 9 files changed, 11 insertions(+), 4 deletions(-) commit 23fc09d4a23a52da48ecc7d08cd2629c2272ce1a Author: Philip Withnall Date: Tue Apr 26 23:56:41 2011 +0100 Add a “debug” command to folks-inspect to print status information When executed, it simply calls Folks.Debug.emit_print_status(). Closes: bgo#648533 NEWS | 1 + tools/inspect/Makefile.am | 1 + tools/inspect/command-debug.vala | 54 ++++++++++++++++++++++++++++++++++++++ tools/inspect/inspect.vala | 1 + 4 files changed, 57 insertions(+), 0 deletions(-) commit 4292b07504c13e70fba6c1b23b1a043cb2120fa3 Author: Philip Withnall Date: Sat Apr 23 01:14:20 2011 +0100 Allow printing out status information at runtime When Folks.Debug.print-status is emitted, BackendStore, IndividualAggregator and Tpf.PersonaStore will now print out their status, including a list of all the loaded backends, persona stores, aggregated individuals and their personas. Folks.Debug.print-status could be emitted as a result of the client process receiving SIGUSR2, for example. Helps: bgo#648533 backends/telepathy/lib/tpf-persona-store.vala | 220 +++++++++++++++++++++++++ folks/backend-store.vala | 69 ++++++++ folks/debug.vala | 50 ++++++ folks/individual-aggregator.vala | 85 ++++++++++ 4 files changed, 424 insertions(+), 0 deletions(-) commit 26ea12bdcfbca8ba00b859a59db357a9608e5b39 Author: Philip Withnall Date: Sun Apr 24 00:22:19 2011 +0100 Add debug printing and formatting methods to Debug This includes indentation and output colouring support. Helps: bgo#648533 folks/backend-store.vala | 4 +- folks/debug.vala | 234 +++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 233 insertions(+), 5 deletions(-) commit ff2d72431787e1cf17697398f9d721f360ec6e7c Author: Philip Withnall Date: Sat Apr 23 01:10:50 2011 +0100 Allow the singleton Debug instance to be retrieved without setting its flags Helps: bgo#648533 folks/backend-store.vala | 3 +- folks/debug.vala | 49 ++++++++++++++++++++++++++++++++------------- 2 files changed, 37 insertions(+), 15 deletions(-) commit 2c71358301f6da87186acf3c3405c55df3c5fe57 Author: Philip Withnall Date: Sat Apr 23 00:58:54 2011 +0100 Allow enabling/disabling output of debug messages at runtime Helps: bgo#648533 folks/debug.vala | 46 ++++++++++++++++++++++++++++++++++++++++++++-- 1 files changed, 44 insertions(+), 2 deletions(-) commit c5ef70859ff19c46f6e3a08a3816a1fc3e0cb6d2 Author: Philip Withnall Date: Mon Apr 25 21:07:38 2011 +0100 Make Debug public and restrict it to being a singleton Also add some API documentation to its newly-public members and make it thread-safe. NEWS | 1 + folks/debug.vala | 80 +++++++++++++++++++++++++++++++++++++---------------- 2 files changed, 57 insertions(+), 24 deletions(-) commit fbd2a2d588541177c1e2441d28f1bc70f7e75c88 Author: Philip Withnall Date: Wed Apr 27 15:49:33 2011 +0100 Bug 648767 — Return read-only views of Sets and Maps where possible This prevents clients from messing up libfolks' state by modifying Sets or Maps returned to them by libfolks when those Sets or Maps are just references to the ones used internally by libfolks, as is the case with many properties. Closes: bgo#648767 backends/key-file/kf-backend.vala | 4 +- backends/key-file/kf-persona-store.vala | 14 ++--- backends/libsocialweb/lib/swf-persona-store.vala | 10 ++-- backends/libsocialweb/lib/swf-persona.vala | 4 +- backends/libsocialweb/sw-backend.vala | 8 ++- backends/telepathy/lib/tpf-persona-store.vala | 28 ++++------ backends/telepathy/lib/tpf-persona.vala | 4 +- backends/telepathy/tp-backend.vala | 4 +- backends/tracker/lib/trf-persona-store.vala | 13 ++-- backends/tracker/lib/trf-persona.vala | 65 ++++++++++++++------- backends/tracker/tr-backend.vala | 4 +- folks/backend-store.vala | 7 ++- folks/field-details.vala | 2 +- folks/individual-aggregator.vala | 66 ++++++++++++++++++---- folks/individual.vala | 38 +++++++++++- folks/persona-store.vala | 30 ++++++++++ folks/postal-address-details.vala | 4 +- 17 files changed, 219 insertions(+), 86 deletions(-) commit e5c020e4e871e328fc401b4dfd2a9935a9fe6b9b Author: Philip Withnall Date: Fri Apr 22 22:47:49 2011 +0100 Tidy up signal disconnections in IndividualAggregator Closes: bgo#645186 NEWS | 1 + folks/individual-aggregator.vala | 26 ++++++++++++++++++++++---- 2 files changed, 23 insertions(+), 4 deletions(-) commit a4c3866f54b4be1b21b401127670ee147d4fc4ee Author: Philip Withnall Date: Fri Apr 22 22:36:13 2011 +0100 Tidy up channel signal disconnections in Tpf.PersonaStore Helps: bgo#645186 backends/telepathy/lib/tpf-persona-store.vala | 53 ++++++++++++++++++++++-- 1 files changed, 48 insertions(+), 5 deletions(-) commit ebe1339328b458db6ecd85d41a9472849b8088eb Author: Philip Withnall Date: Fri Apr 22 22:13:42 2011 +0100 Add a missing signal disconnection to Tr.Backend Helps: bgo#645186 backends/tracker/tr-backend.vala | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit 8e555864fd37e9efb967768fd9b5dc512e7059ce Author: Philip Withnall Date: Fri Apr 22 22:02:59 2011 +0100 Add a missing signal disconnection to Tp.Backend Helps: bgo#645186 backends/telepathy/tp-backend.vala | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit 7fede8525f682559fe23280ad107082d3793b82d Author: Philip Withnall Date: Fri Apr 22 22:01:38 2011 +0100 Add a missing signal disconnection to Kf.Backend Helps: bgo#645186 backends/key-file/kf-backend.vala | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit bc22db53346c24ccb3dc6d53d00ccda125f6e6cf Author: Philip Withnall Date: Fri Apr 22 21:59:14 2011 +0100 Fix a potential crash in Swf.PersonaStore on destruction before preparation If a Swf.PersonaStore is finalised before .prepare() is called, its _contact_view member will be null, so it shouldn't try and disconnect from signals from it. backends/libsocialweb/lib/swf-persona-store.vala | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) commit ce07382fe7eb1bd44858c1d925caed5d2bbd16e8 Author: Maxim Ermilov Date: Fri Apr 22 03:06:51 2011 +0400 Add GObject Introspection Support Closes: bgo#648161 NEWS | 1 + configure.ac | 8 ++++++-- folks/Makefile.am | 21 +++++++++++++++++++++ 3 files changed, 28 insertions(+), 2 deletions(-) commit 50c7885244b085eadc798151b730c635326a25fa Author: Travis Reitter Date: Tue Apr 26 09:59:29 2011 -0700 Add a NEWS entry for fixing bgo#640092. NEWS | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit 42992e45d4441de8378f2c15ae6de157ff9b0ab2 Author: Philip Withnall Date: Wed Apr 20 11:22:18 2011 +0100 Change PostalAddress.types to be a Set Helps: bgo#640092 NEWS | 1 + backends/tracker/lib/trf-persona-store.vala | 4 +- backends/tracker/lib/trf-persona.vala | 4 +- folks/postal-address-details.vala | 25 +++++++++++-------- tests/tracker/add-persona.vala | 4 +- .../tracker/postal-address-details-interface.vala | 2 +- tests/tracker/set-postal-addresses.vala | 4 +- 7 files changed, 24 insertions(+), 20 deletions(-) commit df92a32fc1c0597df616c0bbe57c7d07772ecf93 Author: Philip Withnall Date: Wed Apr 20 01:41:57 2011 +0100 Change PotentialMatch.known_email_aliases to be of type Set Helps: bgo#640092 NEWS | 1 + folks/potential-match.vala | 11 ++++++++++- 2 files changed, 11 insertions(+), 1 deletions(-) commit a1aa6294a48a6cec8b92edd7f7cc73f6047c39cc Author: Philip Withnall Date: Wed Apr 20 01:41:20 2011 +0100 Change RoleDetails.roles to be of type Set Helps: bgo#640092 NEWS | 1 + backends/tracker/lib/trf-persona-store.vala | 2 +- backends/tracker/lib/trf-persona.vala | 2 +- folks/individual.vala | 7 +++++-- folks/role-details.vala | 4 ++-- tests/tracker/add-persona.vala | 4 ++-- tools/inspect/utils.vala | 20 ++++++++++++++++++++ 7 files changed, 32 insertions(+), 8 deletions(-) commit 99d591f3b4888c6ad4f5ca3f89bc187f351fba72 Author: Philip Withnall Date: Wed Apr 20 01:40:50 2011 +0100 Change NoteDetails.notes to be of type Set Helps: bgo#640092 NEWS | 1 + backends/tracker/lib/trf-persona-store.vala | 2 +- backends/tracker/lib/trf-persona.vala | 2 +- folks/individual.vala | 7 +++++-- folks/note-details.vala | 4 ++-- tests/tracker/add-persona.vala | 4 ++-- tools/inspect/utils.vala | 20 ++++++++++++++++++++ 7 files changed, 32 insertions(+), 8 deletions(-) commit 99af9effc77f18bb83c369d48b16513a92cff920 Author: Philip Withnall Date: Wed Apr 20 01:40:10 2011 +0100 Change LocalIdDetails.local_ids to be of type Set Helps: bgo#640092 NEWS | 1 + backends/tracker/lib/trf-persona-store.vala | 12 ++++++------ backends/tracker/lib/trf-persona.vala | 6 ++++-- folks/individual-aggregator.vala | 2 +- folks/individual.vala | 7 +++++-- folks/local-id-details.vala | 4 ++-- tools/inspect/utils.vala | 3 ++- 7 files changed, 21 insertions(+), 14 deletions(-) commit 37a01ab4fdc9e0ac85b850824212a1ed44e8d27e Author: Philip Withnall Date: Wed Apr 20 01:31:54 2011 +0100 Change PersonaStore.personas to be a Map This helps in our quest to get rid of HashTable. Helps: bgo#640092 NEWS | 1 + backends/key-file/kf-persona-store.vala | 20 +++++++++----------- backends/libsocialweb/lib/swf-persona-store.vala | 14 +++++++------- backends/telepathy/lib/tpf-persona-store.vala | 11 +++++------ backends/tracker/lib/trf-persona-store.vala | 20 ++++++++++---------- folks/persona-store.vala | 4 +++- tests/tracker/remove-persona.vala | 4 ++-- tools/inspect/utils.vala | 14 +++++++------- 8 files changed, 44 insertions(+), 44 deletions(-) commit 03bfb40e46b9c804700c57e0a6a6faf6aa503cda Author: Philip Withnall Date: Wed Apr 20 01:14:05 2011 +0100 Change IndividualAggregator.individuals to be a Map This helps in our quest to get rid of HashTable. Helps: bgo#640092 NEWS | 1 + folks/individual-aggregator.vala | 32 +++++++++++++++--------------- tests/tracker/add-contact.vala | 5 +-- tests/tracker/avatar-updates.vala | 2 +- tests/tracker/emails-updates.vala | 2 +- tests/tracker/match-all.vala | 2 +- tests/tracker/match-email-addresses.vala | 4 +- tests/tracker/match-im-addresses.vala | 4 +- tests/tracker/match-known-emails.vala | 4 +- tests/tracker/match-name.vala | 4 +- tests/tracker/match-phone-number.vala | 4 +- tools/inspect/command-individuals.vala | 10 ++++---- tools/inspect/command-personas.vala | 6 +--- tools/inspect/utils.vala | 20 +++++++++--------- 14 files changed, 49 insertions(+), 51 deletions(-) commit 290c04b913002f5630b3ce3a72620f5b9964cae8 Author: Philip Withnall Date: Wed Apr 20 01:02:54 2011 +0100 Change IndividualAggregator.get_[all_]potential_matches() to return a Map We don't want to expose the fact that we're using a *hash* map internally. Helps: bgo#640092 NEWS | 4 ++++ folks/individual-aggregator.vala | 8 ++++---- 2 files changed, 8 insertions(+), 4 deletions(-) commit 2d66369e4196c71aa390405ee82c67dd4af980ca Author: Philip Withnall Date: Wed Apr 20 00:58:00 2011 +0100 Change IndividualAggregator.link_personas() to take a Set Helps: bgo#640092 NEWS | 1 + folks/individual-aggregator.vala | 12 ++++-------- tests/libsocialweb/aggregation.vala | 8 ++++---- tests/tracker/link-personas-via-local-ids.vala | 10 +++++----- tests/tracker/link-personas.vala | 10 +++++----- 5 files changed, 19 insertions(+), 22 deletions(-) commit d27602ca291598b2de3b69b3b32c35784423d244 Author: Philip Withnall Date: Thu Mar 24 16:40:07 2011 +0000 Port IndividualAggregator.individuals_changed to use Set Helps: bgo#640092 NEWS | 2 + folks/individual-aggregator.vala | 30 ++++++++++++-------- tests/key-file/individual-retrieval.vala | 11 ++++-- tests/libsocialweb/aggregation.vala | 18 +++++++---- tests/libsocialweb/dummy-lsw.vala | 12 ++++---- tests/telepathy/individual-properties.vala | 14 ++++---- tests/telepathy/individual-retrieval.vala | 4 +- tests/tracker/add-contact.vala | 8 ++-- tests/tracker/add-persona.vala | 8 ++-- tests/tracker/additional-names-updates.vala | 8 ++-- tests/tracker/avatar-details-interface.vala | 6 ++-- tests/tracker/avatar-updates.vala | 8 ++-- tests/tracker/birthday-details-interface.vala | 8 ++-- tests/tracker/birthday-updates.vala | 8 ++-- tests/tracker/default-contact.vala | 8 ++-- tests/tracker/duplicated-emails.vala | 8 ++-- tests/tracker/duplicated-phones.vala | 8 ++-- tests/tracker/email-details-interface.vala | 8 ++-- tests/tracker/emails-updates.vala | 8 ++-- tests/tracker/family-name-updates.vala | 9 +++-- tests/tracker/favourite-details-interface.vala | 8 ++-- tests/tracker/favourite-updates.vala | 8 ++-- tests/tracker/fullname-updates.vala | 8 ++-- tests/tracker/gender-details-interface.vala | 8 ++-- tests/tracker/given-name-updates.vala | 8 ++-- tests/tracker/im-details-interface.vala | 8 ++-- tests/tracker/imaddresses-updates.vala | 8 ++-- tests/tracker/individual-retrieval.vala | 8 ++-- tests/tracker/link-personas-via-local-ids.vala | 27 +++++++++++------ tests/tracker/link-personas.vala | 27 +++++++++++------ tests/tracker/match-all.vala | 8 ++-- tests/tracker/match-email-addresses.vala | 8 ++-- tests/tracker/match-im-addresses.vala | 8 ++-- tests/tracker/match-known-emails.vala | 8 ++-- tests/tracker/match-name.vala | 8 ++-- tests/tracker/match-phone-number.vala | 8 ++-- tests/tracker/name-details-interface.vala | 8 ++-- tests/tracker/nickname-updates.vala | 8 ++-- tests/tracker/note-details-interface.vala | 8 ++-- tests/tracker/phone-details-interface.vala | 8 ++-- tests/tracker/phones-updates.vala | 8 ++-- .../tracker/postal-address-details-interface.vala | 8 ++-- tests/tracker/prefix-name-updates.vala | 8 ++-- tests/tracker/remove-contact.vala | 8 ++-- tests/tracker/remove-persona.vala | 8 ++-- tests/tracker/role-details-interface.vala | 8 ++-- tests/tracker/set-alias.vala | 8 ++-- tests/tracker/set-avatar.vala | 8 ++-- tests/tracker/set-birthday.vala | 8 ++-- tests/tracker/set-duplicate-email.vala | 8 ++-- tests/tracker/set-emails.vala | 8 ++-- tests/tracker/set-favourite.vala | 8 ++-- tests/tracker/set-full-name.vala | 8 ++-- tests/tracker/set-gender.vala | 8 ++-- tests/tracker/set-im-addresses.vala | 8 ++-- tests/tracker/set-notes.vala | 8 ++-- tests/tracker/set-phones.vala | 8 ++-- tests/tracker/set-postal-addresses.vala | 8 ++-- tests/tracker/set-roles.vala | 8 ++-- tests/tracker/set-structured-name.vala | 8 ++-- tests/tracker/set-urls.vala | 8 ++-- tests/tracker/suffix-name-updates.vala | 8 ++-- tests/tracker/url-details-interface.vala | 8 ++-- tests/tracker/website-updates.vala | 8 ++-- 64 files changed, 307 insertions(+), 277 deletions(-) commit 853d7721b144153a3c1496c012b24e226999f440 Author: Philip Withnall Date: Thu Mar 24 16:11:09 2011 +0000 Fix a race condition in Tpf.PersonaStore The /IndividualRetrieval/aggregator:add test can execute multiple calls to Tpf.PersonaStore.add_persona_from_details() with the same contact ID simultaneously. Since the change to use sets, the fact that only one of the adds is succeeding is no longer hidden by our use of GLib.List. This commit fixes the error handling in Tpf.PersonaStore.add_persona_from_details() to be more resilient to the contact already existing. Helps: bgo#640092 backends/telepathy/lib/tpf-persona-store.vala | 47 ++++++++++++------------- 1 files changed, 23 insertions(+), 24 deletions(-) commit 2d2e1e1096b562c40c1d02a0ecc373287e51b83e Author: Philip Withnall Date: Thu Mar 24 16:09:21 2011 +0000 Remove unused code from Tpf.PersonaStore backends/telepathy/lib/tpf-persona-store.vala | 14 -------------- 1 files changed, 0 insertions(+), 14 deletions(-) commit dd378b72c4bc63567b0ed74d4b319008fbb1c6be Author: Philip Withnall Date: Thu Mar 24 16:07:55 2011 +0000 Port PersonaStore.personas_changed to Set Helps: bgo#640092 NEWS | 1 + backends/key-file/kf-persona-store.vala | 24 +++++--- backends/libsocialweb/lib/swf-persona-store.vala | 29 ++++++--- backends/telepathy/lib/tpf-persona-store.vala | 72 ++++++++++++++-------- backends/tracker/lib/trf-persona-store.vala | 42 ++++++++----- folks/individual-aggregator.vala | 23 +++---- folks/individual.vala | 10 +-- folks/persona-store.vala | 11 ++- 8 files changed, 126 insertions(+), 86 deletions(-) commit 4bb93d34cc916f98d6b0c8fa66e4ef5188ad551e Author: Philip Withnall Date: Thu Mar 24 15:12:00 2011 +0000 Port Individual.personas_changed to use Set Helps: bgo#640092 NEWS | 1 + folks/individual.vala | 33 +++++++++++++++++---------------- 2 files changed, 18 insertions(+), 16 deletions(-) commit aa315bb33900610dae1d4f4093c274488be8f4e4 Author: Philip Withnall Date: Thu Mar 24 11:40:45 2011 +0000 Port Individual.personas to be a Set This is a major user of GLib.List, and porting it should make porting a lot of other stuff a lot easier. Helps: bgo#640092 NEWS | 1 + folks/individual-aggregator.vala | 63 ++++++++++--------------- folks/individual.vala | 69 ++++++++++++++++------------ tests/folks/aggregation.vala | 47 +++++++++++++------ tests/key-file/individual-retrieval.vala | 8 ++- tests/libsocialweb/aggregation.vala | 28 ++++++++---- tests/telepathy/individual-properties.vala | 14 +++++- tests/tracker/add-persona.vala | 11 +++-- tests/tracker/remove-contact.vala | 7 ++- tests/tracker/remove-persona.vala | 9 +++- tests/tracker/set-alias.vala | 35 ++++++++------ tests/tracker/set-avatar.vala | 6 ++- tests/tracker/set-birthday.vala | 6 ++- tests/tracker/set-duplicate-email.vala | 16 ++++--- tests/tracker/set-emails.vala | 7 ++- tests/tracker/set-favourite.vala | 28 +++++++---- tests/tracker/set-full-name.vala | 7 ++- tests/tracker/set-gender.vala | 6 ++- tests/tracker/set-im-addresses.vala | 6 ++- tests/tracker/set-notes.vala | 6 ++- tests/tracker/set-phones.vala | 7 ++- tests/tracker/set-postal-addresses.vala | 6 ++- tests/tracker/set-roles.vala | 6 ++- tests/tracker/set-structured-name.vala | 8 ++- tests/tracker/set-urls.vala | 6 ++- tools/inspect/utils.vala | 19 ++++---- 26 files changed, 262 insertions(+), 170 deletions(-) commit 1c7e4040ef1d916b93f1674efef5ebe1dcb3d0eb Author: Philip Withnall Date: Thu Mar 24 11:00:27 2011 +0000 Convert the internal store of Personas in Individual to use HashSet This converts the private variables in Individual which store its set of Personas to use a single HashSet instead of a separate GLib.List and HashSet. This won't compile, but making all the necessary adjustments to Individual.personas to make it compile would've made the commit too complex to review. The next commit will update Individual.personas. Helps: bgo#640092 folks/individual.vala | 113 +++++++++++++++++++++++++------------------------ 1 files changed, 57 insertions(+), 56 deletions(-) commit eca4e5453097b76557533eadab8d21b7aca90c1a Author: Travis Reitter Date: Thu Feb 3 11:41:38 2011 -0800 Remove use of GLib.List in public BackendStore API. Helps bgo#640092 - Folks should minimize use of GLib.List (including its public API) NEWS | 4 ++ folks/backend-store.vala | 16 ++------ tests/folks/backend-loading.vala | 44 ++++++++++-------------- tests/telepathy/individual-retrieval.vala | 2 +- tests/tracker/add-persona.vala | 2 +- tests/tracker/duplicated-emails.vala | 2 +- tests/tracker/duplicated-phones.vala | 2 +- tests/tracker/link-personas-via-local-ids.vala | 2 +- tests/tracker/link-personas.vala | 2 +- tests/tracker/match-all.vala | 2 +- tests/tracker/match-email-addresses.vala | 2 +- tests/tracker/match-im-addresses.vala | 2 +- tests/tracker/match-known-emails.vala | 2 +- tests/tracker/match-name.vala | 2 +- tests/tracker/match-phone-number.vala | 2 +- tests/tracker/remove-persona.vala | 2 +- tests/tracker/set-duplicate-email.vala | 2 +- 17 files changed, 40 insertions(+), 52 deletions(-) commit cc7b9ac3b058d0734f2df749abc50e71d5797149 Author: Philip Withnall Date: Thu Mar 24 10:05:48 2011 +0000 Use just a HashSet in IndividualAggregator._add_personas() Remove use of GLib.List. Helps: bgo#640092 folks/individual-aggregator.vala | 35 ++++++++++++++--------------------- 1 files changed, 14 insertions(+), 21 deletions(-) commit f8baf37765580eaa497f675f102ef713a67083fe Author: Philip Withnall Date: Tue Apr 19 22:27:27 2011 +0100 Change UrlDetails.urls to be a Set Helps: bgo#640092 NEWS | 1 + backends/libsocialweb/lib/swf-persona.vala | 18 ++-- backends/tracker/lib/trf-persona-store.vala | 115 ++++---------------------- backends/tracker/lib/trf-persona.vala | 22 ++--- folks/individual.vala | 31 +++---- folks/url-details.vala | 5 +- tests/tracker/add-persona.vala | 11 +-- tests/tracker/set-urls.vala | 12 ++-- tests/tracker/website-updates.vala | 4 +- tools/inspect/utils.vala | 23 +----- 10 files changed, 68 insertions(+), 174 deletions(-) commit 6510a5cee80afafeefd507387455c6ebcb66a880 Author: Philip Withnall Date: Tue Apr 19 22:13:01 2011 +0100 Change PhoneDetails.phone_numbers to be a Set Helps: bgo#640092 NEWS | 1 + backends/tracker/lib/trf-persona-store.vala | 104 +++------------------------ backends/tracker/lib/trf-persona.vala | 23 ++---- folks/individual.vala | 35 +++++----- folks/phone-details.vala | 5 +- folks/potential-match.vala | 10 +-- tests/tracker/add-persona.vala | 13 ++-- tests/tracker/duplicated-phones.vala | 18 ++--- tests/tracker/match-phone-number.vala | 16 ++-- tests/tracker/phones-updates.vala | 4 +- tests/tracker/set-phones.vala | 10 ++-- tools/inspect/utils.vala | 6 +- 12 files changed, 74 insertions(+), 171 deletions(-) commit 1d035bd4d12e61b7809b5db251993306f6c170ae Author: Philip Withnall Date: Tue Apr 19 21:55:06 2011 +0100 Change EmailDetails.email_addresses to be a Set Helps: bgo#640092 NEWS | 1 + backends/tracker/lib/trf-persona-store.vala | 96 +++++++++++++++++++++++---- backends/tracker/lib/trf-persona.vala | 23 ++----- folks/email-details.vala | 5 +- folks/individual.vala | 32 ++++----- folks/potential-match.vala | 10 +-- tests/tracker/add-persona.vala | 13 ++-- tests/tracker/duplicated-emails.vala | 16 ++-- tests/tracker/emails-updates.vala | 6 +- tests/tracker/match-email-addresses.vala | 16 ++-- tests/tracker/match-known-emails.vala | 16 ++-- tests/tracker/remove-persona.vala | 11 ++-- tests/tracker/set-duplicate-email.vala | 14 ++-- tests/tracker/set-emails.vala | 10 ++-- tools/inspect/utils.vala | 23 ++++++- 15 files changed, 185 insertions(+), 107 deletions(-) commit f912d31414251e3a87616cdedb46d1d3015ccd53 Author: Philip Withnall Date: Tue Apr 19 21:41:20 2011 +0100 Change PostalAddressDetails.postal_addresses to be a Set Helps: bgo#640092 NEWS | 1 + backends/tracker/lib/trf-persona-store.vala | 66 +++++++++++++-------------- backends/tracker/lib/trf-persona.vala | 27 +++++------- folks/individual.vala | 17 +++---- folks/postal-address-details.vala | 13 +++-- tests/tracker/add-persona.vala | 9 ++-- tests/tracker/set-postal-addresses.vala | 7 +-- tools/inspect/utils.vala | 4 +- 8 files changed, 68 insertions(+), 76 deletions(-) commit 56077a1d890d079e5d0fe6291706a037395db158 Author: Philip Withnall Date: Tue Apr 19 20:59:18 2011 +0100 Change FieldDetails.parameters to be a MultiMap Helps: bgo#640092 NEWS | 3 + backends/tracker/lib/trf-persona-store.vala | 18 +++----- backends/tracker/lib/trf-persona.vala | 23 +++-------- folks/field-details.vala | 59 ++++++++++++--------------- tests/folks/field-details.vala | 34 +++++++--------- tests/tracker/set-urls.vala | 26 +++++++----- 6 files changed, 73 insertions(+), 90 deletions(-) commit 754541d94a53004aa38dfb163f49f9e258930ca5 Author: Philip Withnall Date: Tue Apr 19 20:29:12 2011 +0100 Change GroupDetails.groups to be a Set Helps: bgo#640092 NEWS | 1 + backends/telepathy/lib/tpf-persona.vala | 24 ++++++++---------- folks/group-details.vala | 5 +++- folks/individual.vala | 37 +++++++++++++--------------- tests/telepathy/individual-properties.vala | 6 ++-- tools/inspect/utils.vala | 19 +++++--------- 6 files changed, 43 insertions(+), 49 deletions(-) commit beef9692895520e335770e0035bbec85240a61b1 Author: Philip Withnall Date: Tue Apr 19 19:13:30 2011 +0100 Change Backend.persona_stores to be a Map Helps: bgo#640092 NEWS | 1 + backends/key-file/kf-backend.vala | 20 ++++++++++---------- backends/libsocialweb/sw-backend.vala | 20 ++++++++++---------- backends/telepathy/tp-backend.vala | 22 +++++++++++----------- backends/tracker/tr-backend.vala | 20 ++++++++++---------- folks/backend.vala | 5 ++++- folks/individual-aggregator.vala | 7 +++---- tests/telepathy/individual-retrieval.vala | 3 +-- tests/telepathy/persona-store-capabilities.vala | 2 +- tests/tracker/add-persona.vala | 2 +- tests/tracker/duplicated-emails.vala | 2 +- tests/tracker/duplicated-phones.vala | 2 +- tests/tracker/link-personas-via-local-ids.vala | 2 +- tests/tracker/link-personas.vala | 2 +- tests/tracker/match-all.vala | 2 +- tests/tracker/match-email-addresses.vala | 2 +- tests/tracker/match-im-addresses.vala | 2 +- tests/tracker/match-known-emails.vala | 2 +- tests/tracker/match-name.vala | 2 +- tests/tracker/match-phone-number.vala | 2 +- tests/tracker/remove-persona.vala | 2 +- tests/tracker/set-duplicate-email.vala | 2 +- tools/import.vala | 15 ++++++++++----- tools/inspect/command-backends.vala | 7 +++---- tools/inspect/command-persona-stores.vala | 12 ++++++------ tools/inspect/utils.vala | 9 ++++----- 26 files changed, 87 insertions(+), 82 deletions(-) commit f45fcbb3b1eb92feed741a1a513265d30624aaa8 Author: Philip Withnall Date: Tue Apr 19 18:57:46 2011 +0100 Remove LinkedHashSet in favour of Gee.HashSet Helps: bgo#640092 NEWS | 1 + folks/Makefile.am | 1 - folks/linked-hash-set.vala | 377 ----------------------------------- tests/folks/Makefile.am | 6 - tests/folks/linked-hash-set.vala | 404 -------------------------------------- 5 files changed, 1 insertions(+), 788 deletions(-) commit 4b28646ea714d9322f09c35095716887ac200115 Author: Philip Withnall Date: Tue Apr 19 18:43:18 2011 +0100 Change WebServiceDetails.…addresses to be a MultiMap Helps: bgo#640092 NEWS | 2 + backends/key-file/kf-persona-store.vala | 4 +- backends/key-file/kf-persona.vala | 42 ++++++++++++-------------- backends/libsocialweb/lib/swf-persona.vala | 11 ++---- backends/tracker/lib/trf-persona-store.vala | 28 +++++++---------- backends/tracker/lib/trf-persona.vala | 17 ++++++----- folks/individual-aggregator.vala | 25 +++++++--------- folks/individual.vala | 27 +++++++--------- folks/web-service-details.vala | 11 ++---- tools/inspect/utils.vala | 12 +++---- 10 files changed, 80 insertions(+), 99 deletions(-) commit 6b5c6befa0a4c392a1ffb6516963a0cbbbb1e4bd Author: Philip Withnall Date: Tue Apr 19 18:12:15 2011 +0100 Change ImDetails.im_addresses to be a MultiMap Helps: bgo#640092 NEWS | 1 + backends/key-file/kf-persona-store.vala | 6 +- backends/key-file/kf-persona.vala | 55 +++++-------- backends/libsocialweb/lib/swf-persona.vala | 12 +-- backends/telepathy/lib/tpf-persona.vala | 17 ++--- backends/tracker/lib/trf-persona-store.vala | 118 ++++++++++++++++++++++----- backends/tracker/lib/trf-persona.vala | 52 ++++--------- folks/im-details.vala | 13 ++-- folks/individual-aggregator.vala | 28 +++---- folks/individual.vala | 25 +++--- folks/potential-match.vala | 16 +--- tests/tracker/add-persona.vala | 17 ++--- tests/tracker/im-details-interface.vala | 2 +- tests/tracker/imaddresses-updates.vala | 14 ++-- tests/tracker/link-personas.vala | 24 ++---- tests/tracker/match-im-addresses.vala | 27 +++---- tests/tracker/set-im-addresses.vala | 24 ++---- tools/import-pidgin.vala | 20 +---- tools/inspect/utils.vala | 14 ++-- 19 files changed, 235 insertions(+), 250 deletions(-) commit 858e80d7649ebe7af0553531a940098f6d3c8449 Author: Philip Withnall Date: Thu Mar 24 13:19:12 2011 +0000 Add navigation tests for LinkedHashSet.Iterator Helps: bgo#645684 tests/folks/linked-hash-set.vala | 59 ++++++++++++++++++++++++++++++++++++++ 1 files changed, 59 insertions(+), 0 deletions(-) commit 61ed5af3594831015fd52cf4c548ff1840ec334f Author: Philip Withnall Date: Thu Mar 24 12:31:42 2011 +0000 Implement an Iterator for LinkedHashSet In order to ensure that calling Iterator.remove() on an iterator returned by LinkedHashSet.iterator() actually removes the item from both the linked list and hash set in the LinkedHashSet, we have to subclass Iterator ourselves. This means that all the LinkedHashSet tests pass once more. Closes: bgo#645684 NEWS | 3 ++ folks/linked-hash-set.vala | 77 ++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 78 insertions(+), 2 deletions(-) commit 34e89c9fdeba10c52238831cd6303fa7a2e9e2c3 Author: Philip Withnall Date: Thu Mar 24 12:19:32 2011 +0000 Add stamping to LinkedHashSet Since we don't have access to the stamps in the LinkedHashSet's linked list or hash set, we have to maintain our own. This is necessary for implementing our own Iterator. (See next commit.) Helps: bgo#645684 folks/linked-hash-set.vala | 11 ++++++++++- 1 files changed, 10 insertions(+), 1 deletions(-) commit f311735144325c44de2c542415fcf65913d9e286 Author: Philip Withnall Date: Thu Mar 24 12:08:28 2011 +0000 Remove implementation of LinkedHashSet.list_iterator() The extra methods provided by ListIterator are all incompatible with the set qualities of LinkedHashSet, and would allow duplicate entries to be introduced into the set. LinkedHashSet.iterator() continues to return an iterator which uses the links in LinkedHashSet to provide fast iteration. Helps: bgo#645684 NEWS | 3 +++ folks/linked-hash-set.vala | 7 +++---- 2 files changed, 6 insertions(+), 4 deletions(-) commit c6f44b505999d259af5b262a69e57da31af611d0 Author: Philip Withnall Date: Thu Mar 24 11:57:24 2011 +0000 Add tests for LinkedHashSet.iterator() Helps: bgo#645684 tests/folks/linked-hash-set.vala | 49 ++++++++++++++++++++++++++++++++++++++ 1 files changed, 49 insertions(+), 0 deletions(-) commit 9fa57c03a51e4c5b4eaf04642ebab7a52d62003f Author: Philip Withnall Date: Tue Apr 12 20:42:06 2011 +0100 Don't remove the wrong Individuals from IndividualAggregator In IndividualAggregator._individual_removed_cb(), don't remove the individual from IndividualAggregator.individuals unless it is actually the individual which is emitting the "removed" signal. Closes: bgo#647121 NEWS | 2 ++ folks/individual-aggregator.vala | 8 ++++---- 2 files changed, 6 insertions(+), 4 deletions(-) commit ce370e34d73fc1fb13781cf59f29efe5553000ca Author: Philip Withnall Date: Sat Jan 22 11:34:53 2011 +0000 Fix Tpf.Persona to use its store's ID in persona UIDs It was previously (incorrectly) not using the PersonaStore's ID as the middle component in its UID, which meant that the same IM address as added on two different accounts using the same protocol would have the same UID, undermining the concept of a UID as a globally unique identifier for a Persona. Closes: bgo#647121 backends/telepathy/lib/tpf-persona.vala | 2 +- tests/folks/aggregation.vala | 15 ++++++++++----- tests/telepathy/individual-properties.vala | 3 ++- tests/telepathy/individual-retrieval.vala | 3 ++- 4 files changed, 15 insertions(+), 8 deletions(-) commit 0517262c104a2c30c621ab180f1b4ac6e2b47b13 Author: Philip Withnall Date: Tue Apr 12 16:08:40 2011 +0100 Bug 647562 — Don't crash on duplicate group channels NEWS | 1 + backends/telepathy/lib/tpf-persona-store.vala | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 0 deletions(-) commit f9f5fddf944218530316e4191ca82bafc9b37160 Author: Travis Reitter Date: Fri Apr 15 16:53:03 2011 -0700 Add download-page and bug-database entries to DOAP file. folks.doap | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) commit 1ca419bc64c94e750afbba4cca5811da99d02b7f Author: Travis Reitter Date: Fri Apr 15 16:51:36 2011 -0700 Add a (long) description to the DOAP file. folks.doap | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) commit 9f457074278f8f8d7e4e3885f2c120ca157ff228 Author: Guillaume Desmottes Date: Tue Apr 12 15:00:38 2011 +0100 Bug 645388 — Group channels are leaked NEWS | 3 +++ backends/telepathy/lib/tp-lowlevel.c | 2 ++ backends/telepathy/lib/tp-lowlevel.h | 2 +- 3 files changed, 6 insertions(+), 1 deletions(-) commit 9a85048406949a4cbe787638a81571a5df9973cf Author: Travis Reitter Date: Tue Apr 12 01:26:29 2011 -0700 Post-release version bump. NEWS | 3 +++ configure.ac | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-)